fix: json body prettify not working with comments #1831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added Microsoft's node-jsonc-parser library that is able to format json with comments. Seems to handle bigints properly too. It may be good to consider replacing existing `decomment` library with `jsonc-parser` if its only use case is to decomment json. Fixes usebruno#1830
|
Merged! Thank you @asonkeri ! |
slowjoe007
pushed a commit
to slowjoe007/bruno
that referenced
this pull request
Apr 10, 2024
Added Microsoft's node-jsonc-parser library that is able to format json with comments. Seems to handle bigints properly too. It may be good to consider replacing existing `decomment` library with `jsonc-parser` if its only use case is to decomment json. Fixes usebruno#1830 Co-authored-by: Anoop M D <anoop.md1421@gmail.com>
Its-treason
pushed a commit
to Its-treason/bruno
that referenced
this pull request
Apr 13, 2024
Added Microsoft's node-jsonc-parser library that is able to format json with comments. Seems to handle bigints properly too. It may be good to consider replacing existing `decomment` library with `jsonc-parser` if its only use case is to decomment json. Fixes usebruno#1830 Co-authored-by: Anoop M D <anoop.md1421@gmail.com>
lizziemac
pushed a commit
to lizziemac/bruno
that referenced
this pull request
May 4, 2024
Added Microsoft's node-jsonc-parser library that is able to format json with comments. Seems to handle bigints properly too. It may be good to consider replacing existing `decomment` library with `jsonc-parser` if its only use case is to decomment json. Fixes usebruno#1830 Co-authored-by: Anoop M D <anoop.md1421@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Microsoft's node-jsonc-parser library that is able to format json with comments. Seems to handle bigints properly too.
It may be good to consider replacing existing
decommentlibrary withjsonc-parserif its only use case is to decomment json.Fixes #1830
Before. Failing to prettify JSON body with comments:
After. JSON body properly formatted:
Description
Contribution Checklist:
Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.
Publishing to New Package Managers
Please see here for more information.