Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1935 - Underlying components no longer overlap modals #1936

Merged

Conversation

david-reichert-ef
Copy link
Contributor

Fixes #1935

Description

I've adjusted the modal z-index to ensure that underlying components do not overlap the modal. This change ensures that the prettier button in a POST body no longer overlaps modal windows.

Before

Before

After

After

Contribution Checklist:

  • The pull request only addresses one issue or adds one feature.
  • The pull request does not introduce any breaking changes
  • I have added screenshots or gifs to help explain the change if applicable.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.

Publishing to New Package Managers

Please see here for more information.

Adjusting modal z-index to ensure that underlying components do not overlap the modal. This change ensures that the prettier button in a POST body no longer overlaps modal windows.
@david-reichert-ef david-reichert-ef changed the title Fixes XX - Underlying components no longer overlap modals Fixes #1935 - Underlying components no longer overlap modals Mar 26, 2024
@helloanoop helloanoop merged commit c9e40cb into usebruno:main Apr 9, 2024
@helloanoop
Copy link
Contributor

Merged!

Thank you @david-reichert-ef !

slowjoe007 pushed a commit to slowjoe007/bruno that referenced this pull request Apr 10, 2024
Adjusting modal z-index to ensure that underlying components do not overlap the modal. This change ensures that the prettier button in a POST body no longer overlaps modal windows.
Its-treason pushed a commit to Its-treason/bruno that referenced this pull request Apr 13, 2024
Adjusting modal z-index to ensure that underlying components do not overlap the modal. This change ensures that the prettier button in a POST body no longer overlaps modal windows.
lizziemac pushed a commit to lizziemac/bruno that referenced this pull request May 4, 2024
Adjusting modal z-index to ensure that underlying components do not overlap the modal. This change ensures that the prettier button in a POST body no longer overlaps modal windows.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Underlying components sometimes overlap modals
3 participants