Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error in actions about older node JS version #1960

Merged
merged 1 commit into from Apr 9, 2024

Conversation

Jean-BaptisteC
Copy link
Contributor

Description

Publish to SnapCraft use checkout v3 to download git repository but this version use node JS 16 and this version is deprecated.
I have bump checkout actions to v4 and not setup node actions because I have see you use node JS 18.

Contribution Checklist:

  • The pull request only addresses one issue or adds one feature.
  • The pull request does not introduce any breaking changes
  • I have added screenshots or gifs to help explain the change if applicable.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

@helloanoop helloanoop merged commit 5a31daf into usebruno:main Apr 9, 2024
@helloanoop
Copy link
Contributor

Merged. Thank you @Jean-BaptisteC !

@Jean-BaptisteC Jean-BaptisteC deleted the bump_actions branch April 10, 2024 04:33
slowjoe007 pushed a commit to slowjoe007/bruno that referenced this pull request Apr 10, 2024
Its-treason pushed a commit to Its-treason/bruno that referenced this pull request Apr 13, 2024
lizziemac pushed a commit to lizziemac/bruno that referenced this pull request May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants