Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix content-type in client_credentials oauth flow #2039

Merged

Conversation

PushpenderSaini0
Copy link
Contributor

Description

I was getting error while using the client credential oauth flow on login.microsoftonline.com

As per RFC 6749 section-4.4 the client credential grant must have "application/x-www-form-urlencoded" format !
This PR adds the format as a header !

I have verified this fixes the issue 馃槃 !

  • Before
  • image
  • After the fix
  • image

Fixes #1987
Fixes #1976
Fixes #1938

Contribution Checklist:

  • The pull request only addresses one issue or adds one feature.
  • The pull request does not introduce any breaking changes
  • I have added screenshots or gifs to help explain the change if applicable.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

@helloanoop helloanoop merged commit 484f6ef into usebruno:main Apr 9, 2024
@helloanoop
Copy link
Contributor

Merged!

Thank you @PushpenderSaini0 !

This will go out in the 1.13.0 release. Please subscribe to Discord announcement channel to stay notified on the releases.

cc @lohit-1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants