feat: Improvements to OAuth2-related user interface #2077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pietrygamat
changed the title
pietrygamat
force-pushed
the
feature/inherit-oauth
branch
from
c962014
to
50a5d16
Compare
pietrygamat
changed the title
This was referenced Apr 14, 2024
pietrygamat
force-pushed
the
feature/inherit-oauth
branch
4 times, most recently
from
1ea0338
to
6f58145
Compare
VictorioBerra
referenced
this pull request
Apr 29, 2024
lizziemac
reviewed
May 4, 2024
packages/bruno-app/src/components/CollectionSettings/Auth/OAuth2/CredentialsPreview/index.js
Outdated
Show resolved
Hide resolved
packages/bruno-app/src/components/RequestPane/Auth/OAuth2/CredentialsPreview/index.js
Outdated
Show resolved
Hide resolved
pietrygamat
force-pushed
the
feature/inherit-oauth
branch
2 times, most recently
from
82c01cf
to
b1b699a
Compare
|
Looks great, I'm not sure but it looks like one of your other PRs (implicit grant) snuck in here |
It's kind of on purpose - they build up on top of eachother - the implicit grant actually requires dropping the current approach of transforming user request into token request and automatically setting Bearer token instead. I hope to get some definitive feedback from @helloanoop @sanjai0py or other maintainers on wheter the feature is unwelcome, and if so, adjust the PRs accordingly, but having two (or actually three if counting #2164) conflicting PRs is something I want to avoid. |
pietrygamat
force-pushed
the
feature/inherit-oauth
branch
3 times, most recently
from
3d6ce16
to
5744e7f
Compare
This was referenced May 5, 2024
pietrygamat
force-pushed
the
feature/inherit-oauth
branch
from
5744e7f
to
a5e2d09
Compare
pietrygamat
force-pushed
the
feature/inherit-oauth
branch
2 times, most recently
from
5890931
to
733ed88
Compare
5 tasks
2 tasks
… of api endpoint Setting oauth2 authorization no longer equals overwriting user-specified data in a request. The pre-requests made to obtain oauth2 access_token are now separated from actual API request. usebruno#1999
Results of oauth2 authorization flow (i.e. access_token but also refresh_token, id_token, scope or any other information returned from token request) are stored in a collection specific cache. It is persisted in the file system, and will be automatically reused when executing requests until the cache is purged (using Clear Cache button available in all related views).
…able by scripts The new variable 'credentials' is now available in 'req' object. It is added automatically during request preparation if oauth2 method is used and is value is either evaluated or retrieved from collection oauth2 cache.
…Token action The actual the authorization request is now part of request preparation, and its response is returned for post-request script processing.
According to RFC6749 Section 7.1, The client MUST NOT use an access token if it does not understand the token type. At this point bruno only understands 'bearer' token_type.
pietrygamat
force-pushed
the
feature/inherit-oauth
branch
from
733ed88
to
a39f750
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Redesign of OAuth2 UI. Shows tokens and other information obtained from Authorization Server in separate (rudimentary) part of UI, decoupling them from information coming from actual user request. With this change it is now possible to inherit OAuth2 configuration from collection level.
This PR is a continuation of work started in #2061 where caching of access token was first implemented (currently pending review).
Request level view:
Collection level
Contribution Checklist:
resolves #1999
resolves #2074
resolves #1704