Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Bruno language parser to support multiline text blocks #2086

Merged
merged 6 commits into from
Apr 17, 2024

Conversation

sanjai0py
Copy link
Collaborator

@sanjai0py sanjai0py commented Apr 15, 2024

Description

Screen.Recording.2024-04-17.at.10.34.59.AM.mov

Fixes #1138

Contribution Checklist:

  • The pull request only addresses one issue or adds one feature.
  • The pull request does not introduce any breaking changes
  • I have added screenshots or gifs to help explain the change if applicable.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.

Publishing to New Package Managers

Please see here for more information.

@sanjai0py sanjai0py marked this pull request as ready for review April 16, 2024 05:57
@helloanoop helloanoop merged commit a0860fe into usebruno:main Apr 17, 2024
3 checks passed
@helloanoop
Copy link
Contributor

Merged. Thank you @sanjai0py !

@sanjai0py sanjai0py deleted the fix/multiline-string branch April 18, 2024 07:54
@timcoffman
Copy link

It looks to me like this only applies to body parameter values, but does not apply to other areas of the UI such as environment values.

lizziemac pushed a commit to lizziemac/bruno that referenced this pull request May 4, 2024
…runo#2086)

* Refactor Bruno language parser to support multiline text blocks

* Refactor SingleLineEditor component to allow newlines and adjust height dynamically

* Refactor SingleLineEditor component to fix overflow issue

* Fix overflow issue in SingleLineEditor component

* Refactor SingleLineEditor and MultiLineEditor components to fix overflow issues and allow newlines

* Fix overflow and scrolling issues in MultiLineEditor component

---------

Co-authored-by: Sanjai Kumar <sk@sk.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Multiline strings in Form URL Encoded bodies
3 participants