Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: OAuth 2.0 Grant Type Authorization: "invalid_client" error / URL Encode of Client ID #2129

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: OAuth 2.0 Grant Type Authorization: "invalid_client" error / URL Encode of Client ID #2129

wants to merge 1 commit into from
+9 −9

Conversation

pietrygamat
Copy link
Contributor

@pietrygamat pietrygamat commented Apr 18, 2024 •
edited
Loading

Description

Fixes issue where OAuth2 parametrs handled by bruno were not url encoded in final request.

fixes #2115
#1003

Contribution Checklist:

  • The pull request only addresses one issue or adds one feature.
  • The pull request does not introduce any breaking changes
  • I have added screenshots or gifs to help explain the change if applicable.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

@pietrygamat pietrygamat changed the title Fix: OAuth 2.0 Grant Type Authorization: "invalid_client" error / URL Encode of Client ID fix: OAuth 2.0 Grant Type Authorization: "invalid_client" error / URL Encode of Client ID Apr 18, 2024
andreassiegel
andreassiegel approved these changes Apr 26, 2024
View reviewed changes
Copy link
Contributor

@andreassiegel andreassiegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Using the URL class is a nice improvement compared to string concatenation.

packages/bruno-electron/src/ipc/network/oauth2-helper.js
Comment on lines -51 to +54
let oauth2QueryParams =
(authorizationUrl.indexOf('?') > -1 ? '&' : '?') + `client_id=${clientId}&response_type=code`;
const authorizationUrlWithQueryParams = new URL(authorizationUrl);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using the URL class to construct the request URL looks a lot cleaner than the previous string concatenation with some nested ternary operator in the middle. 👍

@ventsislav-georgiev
Copy link

Any progress here?

@werge2121
Copy link

+1 Would like to see this merged in, getting the same error.

@pietrygamat pietrygamat force-pushed the bugfix/2115 branch 2 times, most recently from 30e80b4 to bacbd04 Compare June 5, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreassiegel andreassiegel andreassiegel approved these changes

Assignees
No one assigned
Labels
pr-bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OAuth 2.0 Grant Type Authorization: "invalid_client" error / URL Encode of Client ID for vertical bar
5 participants
@pietrygamat @ventsislav-georgiev @werge2121 @andreassiegel @sanjai0py