-
-
Notifications
You must be signed in to change notification settings - Fork 983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add recursive interpolate #2234
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
Just the test to update
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no tests for duplicated variable in input string. Is that behaviour a bug or a feature ?
I don't see why I can't have 'VAR1={{VAR2}} {{VAR2}}' I will write a test for this case to cover this |
@jeremygau fixed this too |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Good job @leoferreiralima
Thanks for implementing this feature
Hope it will be released soon
Thanks @jeremygau, i expected this to be released soon too! |
@jeremygau / @helloanoop It missed the v1.18.0: is there any chance that this fix will be in the next release ? |
@Benoit12345 like you I waiting the PR to be looked by a maintainer (whiwch I am not) |
@leoferreiralima |
@leoferreiralima your help on your PR will be very useful if you have enough time to have a look for the next release please ? |
Ty @jeremygau However, regarding scripting it seems |
We are prioritising this. Will share more updates later this week. |
fixes #2227
Description
Add option to compose env variables with recursion
Contribution Checklist:
Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.
Publishing to New Package Managers
Please see here for more information.