-
-
Notifications
You must be signed in to change notification settings - Fork 975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bruno Docs #463
Bruno Docs #463
Conversation
@donus3 This is nuts . Truly ❤️❤️❤️ Gonna review this PR today and have this merged. |
8a01aa6
to
781d747
Compare
Hi @donus3 I have one feedback. For now, let's add a new tab called as Everything else looks good, Can you make this change ? PS: We can revisit the approach later to provide the docs in a sidebar. |
Hi @helloanoop Thank you for the feedback and I understand your concerns. I've updated the as per your comment please help recheck the PR. Thank you. |
I would just like to add my vote for the documentation panel being in the sidebar for the following reasons:
|
I like the Docs tab, and I've documented a few of my queries, but lately I've fallen back on simply putting "#" comments directly in the request. This is because it's not obvious which requests have docs and which ones don't. If I write docs for a request, it's probably because they're important information to "future me" about how to use the thing (e.g. "Don't forget to set the ClientId variable first!") In cases like that, I would want the Docs tab to be the first thing I see, or at least be alerted to the fact that docs exist. Perhaps making the tab labels bold when they have anything to say would work, but that would still be too subtle to grab users' attention, and might still get overlooked. Moving the Docs to a lower pane below the other tabs would work at the expense of some vertical space. Only auto-expanding that pane when there are docs to be read would get it out of the way for the majority of requests that don't have docs. I'm not sure what the best UI is. I just know that when I write docs, it's because I want to provide some important information about the request to other users, and I think that information should be more obvious. |
According to #361
This PR implements a documentation feature for each request. The "Docs" button is put by the query URL bar. When it is clicked the documentation section will show on the right side as a new pane.
The document content is a markdown text. This means we just put the markdown inside the docs section in bru or just edit the markdown in the documentation textarea in the app.
To edit the docs
To preview the docs
Hit cmd+s in order to save the document to the bru file
dummy.bru
Open for you all to comment on the design idea. Thank you.