Add GitHub Actions to upload Electron packages to GitHub release #698
+190
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@helloanoop it should be almost okay (the build is currently running on PR only but I'll convert it once every thing is ok) You'll need to define some env var on GitHub (probably here: https://github.com/usebruno/bruno/settings/secrets/actions) to properly sign macOS & Windows build: https://www.electron.build/code-signing Once thing I can figure out is why the Windows build is totally failing with an unhelpful error ... https://github.com/usebruno/bruno/actions/runs/6588337648/job/17900365695?pr=698 
|
j0k3r
changed the title
j0k3r
force-pushed
the
fix/upload-release-package
branch
from
85ea895
to
1168e2a
Compare
|
Ping @helloanoop @j0k3r, can we please merge this? This is for #541. Thanks! |
j0k3r
force-pushed
the
fix/upload-release-package
branch
from
1168e2a
to
656b468
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Attempt to fix #687
Contribution Checklist:
Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.