-
-
Notifications
You must be signed in to change notification settings - Fork 968
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new request from cURL command #840
Conversation
cURL2Request.mp4 |
@snippetkid how does this handle the -k, --insecure flag? Seeing as bruno currently doesn't support disabling TLS/SSL certificate verification on an individual request basis. Looking into the Specifically |
@Olian04 I think your question answers itself. Since bruno doesn't support insecure requests, so does the PR. Neither do I see Apologies but I fail to understand what is improper in this PR. I believe this PR might be a valuable addition for common use cases, even in its current state. What I suggest is an incremental approach. We can proceed with merging this PR to offer this feature to users. This way, we can provide immediate value to users while working towards a more comprehensive feature. I am keen to hear your thoughts on this @helloanoop |
@snippetkid Bruno does support insecure requests. However it only supports it as a global option, not on a request by request basis. I bring up this flag in particular since my current use case for bruno requires some requests to be made insecurely. However I'm sorry but I fail to see how quoting another inadequate implementation (Insomnia) is a good argument for our implementation to also be inadequate. I would accept this PR as an incremental implementation if it parsed all flags but warned the user when an unsupported flag was detected. |
@Olian04 A lot of users are waiting for curl support #338
Can you raise an issue for this. I am not sure how other apps do this at a request level (via UI). We should be able to clearly support an api that can turn of ssl verification at the request level |
Nice work @snippetkid ! Merged !! This will go out in the upcoming 1.1.0 release |
Thanks for the merge @helloanoop 🚀 I'll keenly follow this feature and related issues and come up with ways to improve the curl parsing. Insomnia, Hoppscotch and RecipeUI have their own curl parsing, so I guess we should write our own parser and replace the |
Description
This PR add the capability to create an HTTP request from a valid cURL command (fixes #338)
Contribution Checklist:
Changes:
parse-curl
as a dependency and new utility methodgetRequestFromCurlCommand
to parse cURL commands