Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(indexer): trim contract address #1050

Merged
merged 9 commits into from
Jul 1, 2024
Merged

Conversation

saeta-eth
Copy link
Contributor

No description provided.

Copy link

changeset-bot bot commented May 21, 2024

⚠️ No Changeset found

Latest commit: f6dab33

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

nx-cloud bot commented May 21, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit f6dab33. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Copy link
Contributor

@dbeal-eth dbeal-eth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to be effective, also need to set the address stored in the actual hash (a few lines lower than you already edited)

@mjlescano
Copy link
Contributor

mjlescano commented May 30, 2024

@dbeal-eth could you re-review this one? 🙏 (the requested change is implemented)

@saeta-eth saeta-eth enabled auto-merge (squash) July 1, 2024 18:38
@saeta-eth saeta-eth merged commit 318ccb8 into main Jul 1, 2024
9 checks passed
@saeta-eth saeta-eth deleted the fix/indexer-whitespace-key branch July 1, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants