Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(website): show error when payable value is not valid #1084

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Ignusmart
Copy link
Contributor

This PR aims to prevent client-side crashes due to invalid big integers entered into the payable function's value. Instead, a FormHelper text with an error message is rendered.

Screencast.from.2024-05-30.21-36-28.webm

@Ignusmart Ignusmart self-assigned this May 31, 2024
Copy link

changeset-bot bot commented May 31, 2024

⚠️ No Changeset found

Latest commit: ed8a414

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

nx-cloud bot commented May 31, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit ed8a414. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Copy link
Contributor

@noahlitvin noahlitvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe just isInvalid in on the input (red border) instead of FormHelperText?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants