Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): parsing and application of --gas-price and related #1214

Merged
merged 6 commits into from
Jul 22, 2024

Conversation

dbeal-eth
Copy link
Contributor

the arguments were not parsable or usable at all because they would be passed through multiple processes

now the command works as expected, parsing the inputted value in gwei and converting it early on to avoid ambiguity

the arguments were not parsable or usable at all because they would be passed through multiple
processes

now the command works as expected, parsing the inputted value in gwei and converting it early
on to avoid ambiguity
@dbeal-eth dbeal-eth added the bug Something isn't working label Jul 20, 2024
Copy link

changeset-bot bot commented Jul 20, 2024

⚠️ No Changeset found

Latest commit: 37c9bef

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

nx-cloud bot commented Jul 20, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 37c9bef. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@dbeal-eth dbeal-eth merged commit 94145ca into main Jul 22, 2024
8 of 9 checks passed
@dbeal-eth dbeal-eth deleted the fix-gwei-accounting branch July 22, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants