Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(registry): remove multicall payable #708

Merged
merged 2 commits into from
Jan 11, 2024
Merged

fix(registry): remove multicall payable #708

merged 2 commits into from
Jan 11, 2024

Conversation

saeta-eth
Copy link
Contributor

@saeta-eth saeta-eth commented Jan 9, 2024

Using multicall payable could be dangerous. Anyone can call the multicall method on the publish functions and pay only 1 wei (current fee) for all these publishes to the registry. It's not a significant issue since this new version of the CannonRegistry isn't deployed yet and it's only 1 wei, but it's easy to introduce a security hole in the future if it's overlooked.

Ref: Uniswap/v3-periphery#52

Copy link

changeset-bot bot commented Jan 9, 2024

⚠️ No Changeset found

Latest commit: bcbd09c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@saeta-eth
Copy link
Contributor Author

Some thoughts: if the payable modifier is removed, the publish function called by themulticall won't work, we may need to re-think the fee or multicall implementation.

@saeta-eth saeta-eth merged commit ab26030 into main Jan 11, 2024
8 checks passed
@saeta-eth saeta-eth deleted the fix/multicall branch January 11, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants