fix(registry): remove multicall payable #708
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
multicall payable
could be dangerous. Anyone can call themulticall
method on thepublish
functions and pay only1 wei
(current fee) for all these publishes to the registry. It's not a significant issue since this new version of the CannonRegistry isn't deployed yet and it's only 1 wei, but it's easy to introduce a security hole in the future if it's overlooked.Ref: Uniswap/v3-periphery#52