New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop gitignoring vendor directory. #10

Closed

dannyvankooten opened this issue Jan 10, 2017 · 1 comment

Contributor

dannyvankooten commented Jan 10, 2017

@metalmatze pointed out why here. :)

Why? This is a common practice to just vendor all Go dependencies in vendor/ and put them into git too. I know you can currently fetch all dependencies that are specified in vendor/vendor.json yet you won't be able to, once someone decides to simply delete their repository. Hence you should just put them in there, otherwise you might not be able to built ana tomorrow anymore.

Contributor Author

dannyvankooten commented Jan 13, 2017

Closed by b3f47e3

dannyvankooten closed this as completed

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment