New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added clearSave function to Data class. #142
Conversation
I'd personally call it
|
I'm a fan of On Fri, Nov 21, 2014 at 2:30 PM, Jacob Albano notifications@github.com
|
I'm here, but Jacob seems to have answered himself? |
This looks fine to me, merging! |
Added clearSave function to Data class.
The only other suggestion I have is that |
@Rolpege I was in the middle of writing a comment when you merged, haha. Could you take a look at my suggestion if you missed it? |
My fault! Yes, I agree. Also, maybe flushing after clearing would be a good idea? |
I'm torn about that...it seems like the logical progression, but I feel like there should be a way to clear data without also saving it. Since the save/flush step already exists in a separate function, I feel like it would be best if saving was left as its own discrete step and not implied by the clear step. |
Yeah, probably. So, want to add to this pull request or how do we do it? :D |
This would be particularly useful either for resetting the game or to erase wrongly saved values.