Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove state from I18nProvider #25

Merged
merged 1 commit into from
Jan 17, 2022
Merged

Conversation

Drapegnik
Copy link
Contributor

fix #24

  1. why you create new rosetta instance on every update? - just set works fine
  2. when you set instance state - it leads to 1 extra render - I use ref instead

@vercel
Copy link

vercel bot commented Sep 17, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/flyyer/next-rosetta/77dEHusnJtLiU7ACCPxu4TQVq6XJ
✅ Preview: https://next-rosetta-git-fork-drapegnik-main-flyyer.vercel.app

@lopezjurip
Copy link
Member

Thanks for the contribution @Drapegnik, I'm going to test it during this week. In the meantime I released your PR with tag useref on npm:

npm install --save next-rosetta@useref
yarn add next-rosetta@useref

@Drapegnik
Copy link
Contributor Author

@lopezjurip, hi! any updates?

@lopezjurip lopezjurip merged commit c77ca20 into useflyyer:main Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stale dict after next.js client navigation
2 participants