Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Interpreter::is_user_function() using std::option #12

Closed
usefulmove opened this issue Jul 5, 2022 · 1 comment
Closed

Implement Interpreter::is_user_function() using std::option #12

usefulmove opened this issue Jul 5, 2022 · 1 comment
Labels
good first issue Good for newcomers maintainability Improve code quality

Comments

@usefulmove
Copy link
Owner

It could be cleaner and would be more idiomatic to implement the Interpreter::is_user_function() method using the Option return type from the std::option module.
@usefulmove usefulmove added good first issue Good for newcomers maintainability Improve code quality labels Jul 5, 2022
@usefulmove
Copy link
Owner Author

usefulmove commented Jul 6, 2022 •
edited
Loading

Implemented and tested on development branch (0.20.4). Will merge into main in the near future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers maintainability Improve code quality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@usefulmove