Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dup still performs a type check #19

Closed
usefulmove opened this issue Jul 11, 2022 · 0 comments
Closed

dup still performs a type check #19

usefulmove opened this issue Jul 11, 2022 · 0 comments
Assignees
@usefulmove
Labels
bug Something isn't working enhancement New feature or request error handling Handle errors gracefully feature request Improve and enhance user experience good first issue Good for newcomers

Comments

@usefulmove
Copy link
Owner

The dup command still requires that the value on the stack be parsable to a float. This is legacy code from before the stack was changed, and is limiting. Duplication should be independent of the value type. Type checks should now happen at the time of command execution.
@usefulmove usefulmove added bug Something isn't working enhancement New feature or request good first issue Good for newcomers error handling Handle errors gracefully feature request Improve and enhance user experience labels Jul 11, 2022
@usefulmove usefulmove self-assigned this Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@usefulmove usefulmove

Labels
bug Something isn't working enhancement New feature or request error handling Handle errors gracefully feature request Improve and enhance user experience good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@usefulmove