Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firebase distribution upload fails #267

Closed
emartynov opened this issue Jan 12, 2022 · 3 comments
Closed

Firebase distribution upload fails #267

emartynov opened this issue Jan 12, 2022 · 3 comments

Comments

@emartynov
Copy link

Hi people, just a question, maybe you have an idea what is happening.

Recently we started getting errors while uploading apk to Firebase distribution:

...
Failed to run aapt dump badging: AndroidManifest.xml:69: error: ERROR getting 'android:icon' attribute: attribute is not a string value 

I checked our manifest files - we don't have any icon specification and I assume we rely on the plugin to add it during the build.

@emartynov
Copy link
Author

Aha, exploring more I found pandulapeter/beagle#89. So maybe it is not related to the plugin but an issue with some dependency.

@mateuszkwiecinski
Copy link
Member

This plugin doesn't modify android:icon attribute 🤔 The way plugin works is it generates variant-specific icon based on resource pointed by the Manifest's android:icon. I'd advise you to inspect merged manifest and generated resources and check if there is anything highlighted as incompatible with your minimum sdk level.

Does the issue go away after you disable the plugin? Are you able to reproduce it manually when you run aapt dump badging? If it is an issue with the plugin - would you be able to provide a repro project?

Looking at the plugin implementation I can't find anything that would be incompatible 👀 Generated resource looks like this where the genrated layer-list contains original resource from android:icon and generated png files - all of it should be supported on every sdk level

@emartynov
Copy link
Author

Thank you so much for checking and messaging!!

I found the situation similar to the ticket I posted - this time it is a biometrics library from Google.

I'm closing since irrelevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants