Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more meaningful error messages around font loading #211

Merged
merged 1 commit into from
Aug 26, 2021

Conversation

mateuszkwiecinski
Copy link
Member

@mateuszkwiecinski mateuszkwiecinski commented Aug 26, 2021

@mateuszkwiecinski mateuszkwiecinski force-pushed the add_meaningful_error_message branch 3 times, most recently from e13e4bf to 231e0eb Compare August 26, 2021 20:09
@codecov
Copy link

codecov bot commented Aug 26, 2021

Codecov Report

Merging #211 (dc4b7ba) into master (e919805) will increase coverage by 1.00%.
The diff coverage is 75.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #211      +/-   ##
============================================
+ Coverage     63.02%   64.02%   +1.00%     
- Complexity       87       93       +6     
============================================
  Files            14       14              
  Lines           549      556       +7     
  Branches         97       99       +2     
============================================
+ Hits            346      356      +10     
  Misses          140      140              
+ Partials         63       60       -3     
Impacted Files Coverage Δ
.../project/starter/easylauncher/filter/FontLoader.kt 66.66% <66.66%> (ø)
.../starter/easylauncher/plugin/EasyLauncherPlugin.kt 84.50% <66.66%> (-0.43%) ⬇️
...ct/starter/easylauncher/filter/ChromeLikeFilter.kt 21.42% <100.00%> (+0.37%) ⬆️
...t/starter/easylauncher/filter/ColorRibbonFilter.kt 65.78% <100.00%> (+0.85%) ⬆️
.../starter/easylauncher/plugin/EasyLauncherConfig.kt 78.75% <0.00%> (+3.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e919805...dc4b7ba. Read the comment docs.

@mateuszkwiecinski mateuszkwiecinski force-pushed the add_meaningful_error_message branch 16 times, most recently from 47fa5be to 47417da Compare August 26, 2021 22:14
@mateuszkwiecinski mateuszkwiecinski marked this pull request as ready for review August 26, 2021 22:29
@mateuszkwiecinski mateuszkwiecinski merged commit 6397bb5 into master Aug 26, 2021
@mateuszkwiecinski mateuszkwiecinski deleted the add_meaningful_error_message branch August 26, 2021 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant