Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce tests to ensure chart image repository/tags exist #187

Open
tobybellwood opened this issue Dec 21, 2020 · 6 comments
Open

introduce tests to ensure chart image repository/tags exist #187

tobybellwood opened this issue Dec 21, 2020 · 6 comments

Comments

@tobybellwood
Copy link
Member

Given the complex inter-relations between the chart versions and lagoon versions, we should introduce a test that ensures that all images referenced in the charts are actually pullable. Currently, there is no output to GitHub Actions if the rollout of a chart fails because of a missing image.

Sun, 20 Dec 2020 23:36:26 GMT
Creating namespace 'lagoon-core-kirjn6x79v'...
Sun, 20 Dec 2020 23:36:26 GMT
namespace/lagoon-core-kirjn6x79v created
Sun, 20 Dec 2020 23:51:33 GMT
Error: timed out waiting for the condition

There's a pretty neat solution at https://github.com/helm-lab/helm-images/blob/master/images.sh using a dry-run to extract the image refs.

@smlx
Copy link
Member

smlx commented Dec 21, 2020

Hey @tobybellwood could you provide a link to an example test run with this issue?

@tobybellwood
Copy link
Member Author

tobybellwood commented Dec 21, 2020

@smlx
Copy link
Member

smlx commented Dec 21, 2020

I'm confused, isn't that error what you want to see?

@tobybellwood
Copy link
Member Author

yeah - sorry - it took a lot of hunting to work out what it was - the initial error was that it "timed out".

This isn't a must-have, just a nice to have -I'll think about it a bit!

@smlx
Copy link
Member

smlx commented Dec 21, 2020

I hunted around in the github action s documentation, couldn't find anything about highlighting logs based on regex.

@smlx
Copy link
Member

smlx commented Oct 13, 2021

Hey I'm just grooming issues - is this still a problem?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants