Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The buildvar flag doesn't support values with commas #333

Closed
rocketeerbkw opened this issue Apr 5, 2024 · 0 comments · Fixed by #334
Closed

The buildvar flag doesn't support values with commas #333

rocketeerbkw opened this issue Apr 5, 2024 · 0 comments · Fixed by #334

Comments

@rocketeerbkw
Copy link
Member

Describe the bug
Attempting to use a comma as part of a buildvar value throws Error: Malformed build variable entry (expects KEY=VALUE).

To Reproduce
Steps to reproduce the behavior:
Run lagoon deploy latest -p example -e main --buildvar LAGOON_SERVICE_TYPES="cli:cli,php:php"

Expected behavior
Since some of the Lagoon env vars require the use of commas, they should not throw errors when used.

Additional context
The buildvar flag uses a StringSlice library type to:

take comma-separated value as arguments and split them accordingly

So both of these are valid: --buildvar KEY1=v --buildvar KEY2=v and --buildvar KEY1=v,KEY2=v. There are some issues in the pflag github that suggest this was fixed, so it could also be an issue with our implementation of buildVarsToMap?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant