Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better naming of queries and mutations to suit permission levels #38

Open
shreddedbacon opened this issue Feb 1, 2024 · 0 comments
Open
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@shreddedbacon
Copy link
Member

As we're seeing more usage of this library amongst our own tooling, and that other people may be using this in their own tools too, we need to be more aware of when a particular function call may require elevated permissions than what general Lagoon RBAC would offer. For example, when a query or mutation requires platform-owner permission or greater, we should make this obvious some how in the query or mutation function name, or namespace them better within the client.

Also, recreating standard queries try to be as RBAC neutral where possible. This would allow for permission errors that would be returned to be genuine based on the requests that the user has performed knowingly. Some of this may not be possible with the current APIs structure, where some fields are retrievable by some roles, but we could still try to be as close to this as possible.

@shreddedbacon shreddedbacon added enhancement New feature or request help wanted Extra attention is needed labels Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant