Docs/storybook locale control #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for uselessdev-datepicker ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Thanks @tomchentw this looks really nice |
uselessdev
approved these changes
May 24, 2022
|
@all-contributors please add @tomchentw for docs and code |
|
I've put up a pull request to add @tomchentw! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the locale control to the Storybook
CustomLocalecomponent. It also upgrades storybook dependencies for the reason below in Notes section. Please feel free to drop the first commit though.Screenshots
Notes
Not sure why, but I have to update the highlighted code at L385 on my machine in order to run Storybook. I tried upgrading Storybook dependencies but it seems no luck.