Allow select the same day in a date range selection #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for uselessdev-datepicker ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
raphaelrochap
changed the title
uselessdev
approved these changes
Aug 30, 2022
|
@all-contributors please add @raphaelrochap for code |
|
I've put up a pull request to add @raphaelrochap! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello guys (again)!
Recently, I opened a Pull Request (#48 Remove condition that prevent to select same day), but unfortunally i could'nt review and rewrite the code, sorry for the late in that PR.
Well, as suggested by @uselessdev (in the PR quoted above), i choose to follow the approach to add a new property call
allowSelectSameDay, that will allow the user to select the sameday in a Calendar, in thestartandenddates.I added too, a new example in the storybook, for the users see this property in action.
All the explanation of why i need this prop, its (again) on #48 PR.
Thanks! :D