Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

urlPrefix disappear in s3 storage option? #3436

Closed
ixxmu opened this issue May 21, 2024 · 3 comments
Closed

urlPrefix disappear in s3 storage option? #3436

ixxmu opened this issue May 21, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@ixxmu
Copy link

ixxmu commented May 21, 2024

Describe the bug

urlPrefix disappear in s3 storage option? It showed in previous version S3 options

Steps to reproduce

just check the s3 storage system

The version of Memos you're using

Version: v0.22.0

Screenshots or additional context

No response

@ixxmu ixxmu added the bug Something isn't working label May 21, 2024
@Somme4096
Copy link
Contributor

Somme4096 commented May 23, 2024

Yes, it did disappear in my environment too. I will research on it.

@enshui
Copy link

enshui commented May 24, 2024

well , 0.21 it is shown ,but latest disappear

@Somme4096
Copy link
Contributor

Removed by this commit: 3209630

The reason for the removal of this feature is described in the v0.22.0 release notes:

S3 Storage related resources will be using pre-signed url and supports synchronized deletion.

And link to original author's message:
#3403 (comment)

We will use presigned urls to provide more secure links. It is recommended to use an S3 API-compatible object store such as cloudflare R2.

@boojack boojack closed this as not planned Won't fix, can't repro, duplicate, stale May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants