Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment count overlooking visibility #3536

Closed
jhcao1024 opened this issue Jun 8, 2024 · 0 comments
Closed

Comment count overlooking visibility #3536

jhcao1024 opened this issue Jun 8, 2024 · 0 comments
Labels
bug Something isn't working Stale
Milestone

Comments

@jhcao1024
Copy link

Describe the bug

It seems that the comment count of a memo fails to take into account the visibility of the comments.

Steps to reproduce

  1. Log in and write a public memo.
  2. Write a public comment and another private one.
  3. Sign out and click the explore tab.
  4. The memo is shown with a comment count of 2 beside the comment icon (it counts both the public and private comments).
  5. Click the comment icon, and only the public comment is visible, which is reasonable.

The version of Memos you're using

v0.22.1

Screenshots or additional context

  1. The view of the user who wrote the 2 comments.
    Screenshot 2024-06-07 at 21 45 31

  2. The view of another user or unlogged-in visitors, showing 2 beside the comment icon.
    Screenshot 2024-06-07 at 21 46 48

  3. The expanded view of the memo (the 2nd user's view), showing only the public comment.
    Screenshot 2024-06-07 at 21 46 59

@jhcao1024 jhcao1024 added the bug Something isn't working label Jun 8, 2024
@boojack boojack added this to the next release milestone Jun 10, 2024
@github-actions github-actions bot added the Stale label Jun 24, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Stale
Projects
None yet
Development

No branches or pull requests

2 participants