Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruby 3.x support #10

Closed
wants to merge 1 commit into from
Closed

Conversation

EtienneDepaulis
Copy link

URI.unescape is obsolete in ruby 3.x:

This method is obsolete and should not be used. Instead, use CGI.escape, URI.encode_www_form or URI.encode_www_form_component depending on your specific use case.

This PR fixes this :)

@swilgosz
Copy link
Contributor

@EtienneDepaulis as you've deleted the original branch, I cannot merge this :( . It simply means, I'll need to re-create the PR, which will not include you as contributors love to avoid that.

@EtienneDepaulis
Copy link
Author

@swilgosz my fix was not working :( (I opened the PR a bit too early)
CGI.unescape does not behave like CGI.unescape sadly

@swilgosz
Copy link
Contributor

@EtienneDepaulis Here is the alternative method and the differences explained.

https://stackoverflow.com/questions/30783879/whats-the-difference-between-cgi-unescape-and-uri-decode-www-form-component

Do you plan to continue working on this? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants