Metadata classes for image and container #204
Conversation
conu/apidefs/metadata.py
Outdated
| @@ -0,0 +1,48 @@ | |||
| class Metadata: | |||
There was a problem hiding this comment.
I guess you want to inherit from object since we need conu to be Python 2 compatible.
See https://stackoverflow.com/questions/15374857/should-all-python-classes-extend-object#answer-15374884
conu/apidefs/metadata.py
Outdated
| creation_timestamp=None, env_variables=None): | ||
| self.name = name | ||
| self.id = id | ||
| self.ports = ports |
There was a problem hiding this comment.
I would remove ports from this list since it has different meaning for container and images.
conu/apidefs/metadata.py
Outdated
| def __init__(self, name=None, id=None, ports=None, labels=None, command=None, | ||
| creation_timestamp=None, env_variables=None): | ||
| self.name = name | ||
| self.id = id |
There was a problem hiding this comment.
please use identifier since id is a builtin python function:
In [1]: help(id)
Help on built-in function id in module __builtin__:
id(...)
id(object) -> integer
Return the identity of an object. This is guaranteed to be unique among
simultaneously existing objects. (Hint: it's the object's memory address.)
conu/apidefs/metadata.py
Outdated
|
|
||
| self.tags = tags | ||
| self.registry = registry | ||
| self.entrypoint = entrypoint |
There was a problem hiding this comment.
since entrypoint is docker-specific, I would remove it from the list and just live with command
conu/apidefs/metadata.py
Outdated
| name=name, id=id, ports=ports, labels=labels, command=command, | ||
| creation_timestamp=creation_timestamp, env_variables=env_variables) | ||
|
|
||
| self.tags = tags |
There was a problem hiding this comment.
could we replace tags and registry with image_names?
| self.image = image | ||
| self.ipv4 = ipv4 | ||
| self.ipv6 = ipv6 | ||
| self.status = status |
There was a problem hiding this comment.
will this be enum? or string?
There was a problem hiding this comment.
enum, I used the values that docker container support.
conu/apidefs/metadata.py
Outdated
| creation_timestamp=creation_timestamp, env_variables=env_variables) | ||
| self.hostname = hostname | ||
| self.image = image | ||
| self.ipv4 = ipv4 |
There was a problem hiding this comment.
we need to think a bit more about network addresses since one container can have more of them
There was a problem hiding this comment.
ipv4 and ipv6 can be lists, what do you think?
There was a problem hiding this comment.
yup, I would probably then name it ipv4_addresses
There was a problem hiding this comment.
can be some ports associated only to some IPs? will we represent this?
There was a problem hiding this comment.
@TomasTomecek ok I agree with name. @dhodovsk what about the dictionary
ipv4_adresses = {"10.0.0.1":8008, "10.0.02":8555} does it make sense?
|
What about docs? I propose doing documentation in next pull request. |
Fixes #72