k8s - Service and Deployment #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenkins/superCI comment
|
jpopelka
reviewed
Jun 13, 2018
| @# use it like this: `make test-in-container TEST_TARGET=tests/integration/test_utils.py`k | ||
| docker run --net=host --rm -v /dev:/dev:ro -v /var/lib/docker:/var/lib/docker:ro --security-opt label=disable --cap-add SYS_ADMIN -e KUBECONFIG=/var/lib/origin/openshift.local.config/master/admin.kubeconfig -ti -v /var/run/docker.sock:/var/run/docker.sock -v $(CURDIR):/src -v $(CURDIR)/pytest-container.ini:/src/pytest.ini $(TEST_IMAGE_NAME) /bin/bash -c "oc login 127.0.0.1:8443 -u developer -p developer -n conu --insecure-skip-tls-verify && make exec-test TEST_TARGET=$(TEST_TARGET)" | ||
|
|
||
| test-k8s-minikube: build-test-container |
There was a problem hiding this comment.
Shouldn't the test-in-container target also have build-test-container as dependency ?
conu/backend/k8s/deployment.py
Outdated
| """ | ||
|
|
||
| print(self.get_status().replicas) | ||
| print(self.get_status().ready_replicas) |
conu/backend/docker/image.py
Outdated
| try: | ||
| pod_instance = api.create_namespaced_pod(namespace=namespace, body=pod) | ||
| except ApiException as e: | ||
| print("Exception when calling CoreV1Api->create_namespaced_pod: %s\n" % e) |
requirements.txt
Outdated
| @@ -2,6 +2,6 @@ enum34>=1.1.6 ; python_version <= '2.7' | |||
| requests | |||
| six | |||
| docker | |||
| openshift | |||
| kubernetes == 6.0.0 | |||
There was a problem hiding this comment.
What about kubernetes >= 6.0.0 ?
jenkins/superCI comment
|
|
I wasn't able to run it locally - also CI is failing. Can you recognize this error? Can you add version of kubernetes python library that supports client.AppsV1Api and similar failing? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains initial work on Service and Deployment k8s primitives.
Changes included:
minor refactor of
pod.py- static method
createfor creatingV1Podobject that we can pass to method creating deploymentminor change in requirements, because of incompatible versions of Kubernetes and Kubernetes python client while creating
AppsV1Apifor deploymentnew target in
Makefile-test-k8s-minikubefor verifying Kubernetes tests locally until new CI is setup. Just run on host machineminikube startandmake test-k8s-minikube