Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List tags #29

Merged
merged 4 commits into from Jan 17, 2019
Merged

List tags #29

merged 4 commits into from Jan 17, 2019

Conversation

phracek
Copy link
Contributor

@phracek phracek commented Dec 14, 2018

Signed-off-by: Petr Stone Hracek phracek@redhat.com

This pull request supports getting list of tags from GitHub.

Signed-off-by: Petr Stone Hracek <phracek@redhat.com>
tool/cli.py Outdated Show resolved Hide resolved
Copy link
Member

@lachmanfrantisek lachmanfrantisek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@phracek thanks.

Just one question about url, otherwise looks good!

If you would like to support also the gitlab, here are the links:

Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
@phracek
Copy link
Contributor Author

phracek commented Jan 16, 2019

GitLab tags are present.

Copy link
Member

@lachmanfrantisek lachmanfrantisek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one typo. Otherwise LGTM. Thanks!

tool/services/github_service.py Outdated Show resolved Hide resolved
Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
Copy link
Member

@lachmanfrantisek lachmanfrantisek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

@lachmanfrantisek lachmanfrantisek merged commit 4f2f85e into packit:master Jan 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants