-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a simplistic SparkplugBSession implementation #91
base: master
Are you sure you want to change the base?
Conversation
f83f9bd
to
de48682
Compare
.dependsOn(core) | ||
.settings( | ||
commonSettings ++ pgpSettings ++ publishingSettings ++ Seq( | ||
name := "fs2-sparkplug", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if it should be rather fs2-mqtt-sparkplug
or fs2-mqtt-sparkplug-b
?
@fcabestre I manually tested this locally with a JS Sparkplug B client and it worked nicely. |
It mostly just forwards to the standard MQTT sessions and converts the messages to and from the Sparkplug B protocol.
Codecov Report
@@ Coverage Diff @@
## master #91 +/- ##
==========================================
- Coverage 29.55% 23.02% -6.53%
==========================================
Files 17 19 +2
Lines 247 317 +70
Branches 6 6
==========================================
Hits 73 73
- Misses 174 244 +70
Continue to review full report at Codecov.
|
Well, contributions are always welcome and I'll happy to merge this early work. Just spare me some time to wrap my head around this and see how to proceed. |
Of course! |
It mostly just forwards to the standard MQTT sessions
and converts the messages to and from the Sparkplug B protocol.