Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ES6 Standard Warnings #35

Closed
askmrsinh opened this issue Apr 4, 2019 · 8 comments
Closed

ES6 Standard Warnings #35

askmrsinh opened this issue Apr 4, 2019 · 8 comments
Assignees

Comments

@askmrsinh
Copy link
Owner

Apr 04 14:33:21 ubuntu gnome-shell[1827]: Some code accessed the property 'METHOD' on the module 'lib'. That property was defined with 'let' or 'const' inside the module. This was previously supported, but is not correct according to the ES6 standard. Any symbols to be exported from a module must be defined with 'var'. The property access will work as previously for the time being, but please fix your code anyway.
Apr 04 14:33:21 ubuntu gnome-shell[1827]: Some code accessed the property 'TRACKPOINTS' on the module 'lib'. That property was defined with 'let' or 'const' inside the module. This was previously supported, but is not correct according to the ES6 standard. Any symbols to be exported from a module must be defined with 'var'. The property access will work as previously for the time being, but please fix your code anyway.
Apr 04 14:33:21 ubuntu gnome-shell[1827]: Some code accessed the property 'SETTINGS_SCHEMA' on the module 'lib'. That property was defined with 'let' or 'const' inside the module. This was previously supported, but is not correct according to the ES6 standard. Any symbols to be exported from a module must be defined with 'var'. The property access will work as previously for the time being, but please fix your code anyway.
Apr 04 14:33:21 ubuntu gnome-shell[1827]: Some code accessed the property 'TOUCHPAD_SETTINGS_SCHEMA' on the module 'lib'. That property was defined with 'let' or 'const' inside the module. This was previously supported, but is not correct according to the ES6 standard. Any symbols to be exported from a module must be defined with 'var'. The property access will work as previously for the time being, but please fix your code anyway.
Apr 04 14:33:21 ubuntu gnome-shell[1827]: Some code accessed the property 'TOUCHPADS' on the module 'lib'. That property was defined with 'let' or 'const' inside the module. This was previously supported, but is not correct according to the ES6 standard. Any symbols to be exported from a module must be defined with 'var'. The property access will work as previously for the time being, but please fix your code anyway.
Apr 04 14:33:21 ubuntu gnome-shell[1827]: Some code accessed the property 'StoragePath' on the module 'lib'. That property was defined with 'let' or 'const' inside the module. This was previously supported, but is not correct according to the ES6 standard. Any symbols to be exported from a module must be defined with 'var'. The property access will work as previously for the time being, but please fix your code anyway.
Apr 04 14:33:21 ubuntu gnome-shell[1827]: Some code accessed the property 'FINGER_TOUCHES' on the module 'lib'. That property was defined with 'let' or 'const' inside the module. This was previously supported, but is not correct according to the ES6 standard. Any symbols to be exported from a module must be defined with 'var'. The property access will work as previously for the time being, but please fix your code anyway.
Apr 04 14:33:21 ubuntu gnome-shell[1827]: Some code accessed the property 'TOUCHSCREENS' on the module 'lib'. That property was defined with 'let' or 'const' inside the module. This was previously supported, but is not correct according to the ES6 standard. Any symbols to be exported from a module must be defined with 'var'. The property access will work as previously for the time being, but please fix your code anyway.
Apr 04 14:33:21 ubuntu gnome-shell[1827]: Some code accessed the property 'PENS' on the module 'lib'. That property was defined with 'let' or 'const' inside the module. This was previously supported, but is not correct according to the ES6 standard. Any symbols to be exported from a module must be defined with 'var'. The property access will work as previously for the time being, but please fix your code anyway.
Apr 04 14:33:21 ubuntu gnome-shell[1827]: Some code accessed the property 'OTHERS' on the module 'lib'. That property was defined with 'let' or 'const' inside the module. This was previously supported, but is not correct according to the ES6 standard. Any symbols to be exported from a module must be defined with 'var'. The property access will work as previously for the time being, but please fix your code anyway.

https://github.com/user501254/TouchpadIndicator/blob/6b9489d963137114d7122a390055f60eca987959/extension.js#L69-L87

@Destroy666x
Copy link

Are you going to fix this (and possibly other ES6 errors) in the near future so that this useful extension works on Ubuntu 19.04?

@askmrsinh
Copy link
Owner Author

askmrsinh commented Apr 24, 2019

Yes, I do intend to fix these (#35, #34) issues.
The upstream changes provide a good opportunity for at least a partial rewrite of the extension while dropping support for older gnome-shell versions. I also want to adopt some good practices like linting and setting up build configuration for the project. I haven't yet started making the changes but hope to do so in the coming month.

Until then, you can use the unstable-3.32 branch if you wish to. (these issues have been fixed, please use the master branch)

@askmrsinh askmrsinh self-assigned this Apr 24, 2019
@askmrsinh askmrsinh mentioned this issue Apr 27, 2019
@askmrsinh
Copy link
Owner Author

@Destroy666x Please check if the current master works for you. Let me know in case of any issues.

@mauriziopinotti
Copy link

@user501254 I can confirm the latest code works on gnome-shell 3.32.

@askmrsinh
Copy link
Owner Author

@mauriziopinotti
Thanks! There are still a couple of things that are stopping me from uploading the new version on the GNOME Shell Extensions website (eg: extension will crash if there are no detectable input devices). Once I have them sorted out, I will update with a new release.

@Totoro83

This comment has been minimized.

@askmrsinh

This comment has been minimized.

@askmrsinh
Copy link
Owner Author

askmrsinh commented Nov 11, 2019

Fixed under v33.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants