-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade modules #717
Merged
Merged
upgrade modules #717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned shoota
Jul 2, 2018
ghost
added
the
in progress
label
Jul 2, 2018
shoota
commented
Jul 2, 2018
@@ -31,8 +31,6 @@ Gruntfile.js | |||
.flowconfig | |||
.documentup.json | |||
.yarn-metadata.json | |||
.*.yml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shoota
commented
Jul 4, 2018
@@ -23,6 +23,22 @@ module.exports = { | |||
filename: '[name].js', | |||
sourceMapFilename: '[name].js.map' | |||
}, | |||
optimization: { | |||
minimizer: [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
v4 syntax
Codecov Report
@@ Coverage Diff @@
## master #717 +/- ##
==========================================
- Coverage 91.55% 91.38% -0.17%
==========================================
Files 23 23
Lines 592 592
Branches 103 103
==========================================
- Hits 542 541 -1
- Misses 26 27 +1
Partials 24 24
|
dkimura
approved these changes
Jul 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Check this pr.
How to check
Check list