Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade modules #717

Merged
merged 9 commits into from
Jul 4, 2018
Merged

upgrade modules #717

merged 9 commits into from
Jul 4, 2018

Conversation

shoota
Copy link
Contributor

@shoota shoota commented Jul 2, 2018

TL;DR

  • upgrade dependencies. (webpack major upgrade is the most big.)
  • fix build errors

Check this pr.

How to check

  • checkout this pr.
  • execute npm scripts

Check list

  • all npm scripts can execute fine.
    • yarn build
    • yarn build:examples
    • yarn clean
    • yarn e2e
    • yarn lint
    • yarn start
    • yarn test
  • all bundles working fine.
  • all bundles signed banner.

@ghost ghost assigned shoota Jul 2, 2018
@ghost ghost added the in progress label Jul 2, 2018
@@ -31,8 +31,6 @@ Gruntfile.js
.flowconfig
.documentup.json
.yarn-metadata.json
.*.yml
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shoota shoota changed the title Packages/upgrade upgrade modules Jul 2, 2018
@@ -23,6 +23,22 @@ module.exports = {
filename: '[name].js',
sourceMapFilename: '[name].js.map'
},
optimization: {
minimizer: [
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v4 syntax

@codecov
Copy link

codecov bot commented Jul 4, 2018

Codecov Report

Merging #717 into master will decrease coverage by 0.16%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #717      +/-   ##
==========================================
- Coverage   91.55%   91.38%   -0.17%     
==========================================
  Files          23       23              
  Lines         592      592              
  Branches      103      103              
==========================================
- Hits          542      541       -1     
- Misses         26       27       +1     
  Partials       24       24
Impacted Files Coverage Δ
packages/agent/src/core.ts 90.62% <0%> (-0.79%) ⬇️

@dkimura dkimura merged commit 94e7ab8 into master Jul 4, 2018
@dkimura dkimura deleted the packages/upgrade branch July 4, 2018 07:20
@ghost ghost removed the QA label Jul 4, 2018
@shoota shoota mentioned this pull request Jul 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants