Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

asset-bundles.json may be parsed as YAML instead of JSON when whitespace is inconsistent #1158

Closed
Silic0nS0ldier opened this issue Apr 27, 2021 · 5 comments
Assignees
Labels
assets Related to the assets feature confirmed bug Something isn't working

Comments

@Silic0nS0ldier
Copy link
Member

https://chat.userfrosting.com/channel/support?msg=8LwJd3GPH5EvKeSiX

To fix this a JSON specific loader should be used instead. As it stands now, parsing is inconsistent causing issues like quotes being seen as part of the string (as opposed to its container).

@Silic0nS0ldier Silic0nS0ldier added confirmed bug Something isn't working assets Related to the assets feature labels Apr 27, 2021
@Silic0nS0ldier Silic0nS0ldier self-assigned this Apr 27, 2021
@lcharette
Copy link
Member

lcharette commented Apr 28, 2021

@Silic0nS0ldier
Copy link
Member Author

Correct

@lcharette
Copy link
Member

lcharette commented Apr 28, 2021

Then I think we should deprecate Json fallback for YAML? The fallback should be done in the end user IMO. @alexweissman though on this? I think you introduced YAML in the first place?

@Silic0nS0ldier
Copy link
Member Author

I'm not even sure the JSON loader ever gets hit, given its supposed to be a superset of JSON. Regardless, deprecation is a must so we don't break things on the next update unintentionally. If it does get hit, then the YAML parser is flawed.

@lcharette
Copy link
Member

Not relevant in UF5 anymore

@lcharette lcharette closed this as not planned Won't fix, can't repro, duplicate, stale Nov 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assets Related to the assets feature confirmed bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants