Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating new User requires Email support #763

Closed
zharding opened this issue Jul 9, 2017 · 4 comments

Comments

@zharding
Copy link

commented Jul 9, 2017

When creating a user in the admin dashboard UF currently enforces the use of email. If your config is missing or incorrect the creation of the user fails. This can be an issue for development as the developer may have chosen to not setup email support. I do this frequently for a few reasons.

Solution
Allow the user to be created with an option to not send an email. In which case a random password would be generated. A second possible solution, if email was opted out, create the user and leave the password blank. The user would remain inactive and the admin would have to manually (re)set the password and then enable the user.

This would of course leave 'flag_verified' as negative and flag_enabled as negative to start. However, if email was opted out, simply mark 'flag_verified' as 1 for true. Manually enabling the account would set the 'flag_disabled' to 1.

This would allow for for expansion into a 'customer' type model or simply easier on the developer lol.

@alexweissman

This comment has been minimized.

Copy link
Member

commented Jul 9, 2017

👍

Please note that flag_verified has nothing to do with this, though. Users created through the admin interface are always automatically verified.

UserFrosting checks to make sure that a user does not have an empty password when they try to log in. So, right now when an admin creates a new user, it sets the password to '', and the user gets an email which lets them set their password.

I think we could just have the option to manually set a password when the admin creates the account (actually, this used to be the only way in V3 😱 ) We could bring this back, along with a "suggest password" tool that generates and displays a random value to the admin.

Obviously this is not a good choice to use in production, but I can see how this would be useful in development/testing.

@lcharette

This comment has been minimized.

Copy link
Member

commented Jul 9, 2017

As discussed in chat earlier, a solution would be to merge the existing "create user" with "change user password" form. When creating a user, the admin could select to enter a password or use the default email mechanism.

@zharding

This comment has been minimized.

Copy link
Author

commented Jul 9, 2017

I concur,

This was something Alex and I discussed. I forgot to add the comment here. However, it has been incorporated into my PR here #764

@alexweissman alexweissman added this to the 4.2.0 milestone Jul 11, 2017

@lcharette lcharette removed this from the 4.2.0 milestone Dec 16, 2017

@lcharette lcharette added this to the 4.4.0 milestone Oct 21, 2018

@lcharette lcharette changed the title Admin - Creating new User requires Email support Creating new User requires Email support Oct 28, 2018

@amosfolz

This comment has been minimized.

Copy link
Contributor

commented Jul 19, 2019

Fixed in #1017

@lcharette lcharette modified the milestones: 4.4.0, 4.3.0 Jul 20, 2019

@lcharette lcharette closed this Jul 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.