Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin - New user password option; set manually OR send email. #764

Closed
wants to merge 5 commits into from

Conversation

@zharding
Copy link
Contributor

commented Jul 9, 2017

The ability to create a user and manually set the password OR have a link sent to allow the user to set their own password. Also refactored the 'user-set-password' modal to separate the form and create a 'form/partials' This gives access to common form parts and allow the re-use of the 'user-set-password' controls.

Original
When creating a user manually there actually had to be a real email attached to the new user and the email settings must be configured and configured correctly.

Purpose
Allow a developer to create a user without needing to send an email if so chosen. This also allows an admin to create a user with a non-existent email.

Original Issue
#763

zharding added 4 commits Jul 9, 2017
Refactored 'user-set-password.html.twig'
Refactored the modal 'user-set-password.html.twig'. Created 'forms/user-set-password.html.twig' and included it in the modal. Also created 'forms/partials/user-set-password.html.twig' to seperate the controls for setting the users password for reuse elsewhere.
Admin Ability to Set pass for new user
When creating a user you can now set the password manually or force the user to create one. Previously an email was the only option and hindered the creation of a user if the email settings were not configured at all or incorrectly.

@zharding zharding changed the title Admin - New user with manually set password Admin - New user password option; set manually OR send email. Jul 11, 2017

@alexweissman alexweissman added this to the 4.2.0 milestone Jul 14, 2017

@lcharette lcharette removed this from the 4.2.0 milestone Dec 16, 2017

@alexweissman alexweissman added this to the 4.2.0 milestone May 14, 2018

@lcharette lcharette modified the milestones: 4.2.0, 4.3.0 Oct 13, 2018

@lcharette lcharette modified the milestones: 4.3.0, 4.4.0 Jan 14, 2019

@amosfolz

This comment has been minimized.

Copy link
Contributor

commented Jul 8, 2019

Is there a reason this was never merged?

@lcharette

This comment has been minimized.

Copy link
Member

commented Jul 9, 2019

Is there a reason this was never merged?

Not sure honestly...

@amosfolz

This comment has been minimized.

Copy link
Contributor

commented Jul 9, 2019

I think this can be closed as this functionality already exists.
Looks like it was manually added in this commit by Alex

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.