Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to latest AdminLTE #994

Closed
lcharette opened this issue Jun 5, 2019 · 7 comments
Closed

Update to latest AdminLTE #994

lcharette opened this issue Jun 5, 2019 · 7 comments
Assignees
@amosfolz
Labels
Breaking Change Creates incompatibility with current version compatibility Compatibility issue with other framework, features up-for-grabs Not assigned yet
Milestone
4.3.0

Comments

@lcharette
Copy link
Member

I had a quick look and even between 2.3.6 (which comes with UF4) and 2.4.10 there are quite a number of changes. There's something like 3 years between these releases which in our world is/feels like ages
@lcharette lcharette added compatibility Compatibility issue with other framework, features Breaking Change Creates incompatibility with current version labels Jun 5, 2019
@lcharette lcharette added this to the 4.3.0 milestone Jun 5, 2019
@lcharette lcharette added the up-for-grabs Not assigned yet label Jun 27, 2019
@amosfolz
Copy link
Contributor

amosfolz commented Jul 6, 2019 •
edited
Loading

Newest release is now 2.4.12

I believe the files that need to be updated are:

  • - core/assets/userfrosting/js/AdminLTE.js
  • - core/assets/userfrosting/js/AdminLTE-custom.js
  • - core/assets/userfrosting/css/AdminLTE.css
  • - core/assets/userfrosting/css/AdminLTE-skins-all.css

@amosfolz
Copy link
Contributor

amosfolz commented Jul 7, 2019

@lcharette do you remember what specifically these lines were meant to fix?

@amosfolz amosfolz mentioned this issue Jul 7, 2019
Merged
@lcharette
Copy link
Member Author

FYI : https://github.com/ColorlibHQ/AdminLTE/releases/tag/v2.4.13

@lcharette
Copy link
Member Author

When upgrading to AdminLTE 3 later on, we should probably try using their NPM repo.

@lcharette
Copy link
Member Author

FYI : https://github.com/ColorlibHQ/AdminLTE/releases/tag/v2.4.14

(They're playing with you :P )

@amosfolz
Copy link
Contributor

Okay, updated to 2.4.14! Only a few lines of code changed.

@amosfolz
Copy link
Contributor

When upgrading to AdminLTE 3 later on, we should probably try using their NPM repo.

I'm not sure if it will be the same using their NPM repo or not, but the package is pretty large when downloading the ZIP file.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amosfolz amosfolz

Labels
Breaking Change Creates incompatibility with current version compatibility Compatibility issue with other framework, features up-for-grabs Not assigned yet
Projects
None yet
Milestone
4.3.0
Development

No branches or pull requests
2 participants
@lcharette @amosfolz