Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest AdminLTE #994

Closed
lcharette opened this issue Jun 5, 2019 · 7 comments

Comments

@lcharette
Copy link
Member

commented Jun 5, 2019

I had a quick look and even between 2.3.6 (which comes with UF4) and 2.4.10 there are quite a number of changes. There's something like 3 years between these releases which in our world is/feels like ages

@amosfolz

This comment has been minimized.

Copy link
Contributor

commented Jul 6, 2019

Newest release is now 2.4.12

I believe the files that need to be updated are:

  • - core/assets/userfrosting/js/AdminLTE.js
  • - core/assets/userfrosting/js/AdminLTE-custom.js
  • - core/assets/userfrosting/css/AdminLTE.css
  • - core/assets/userfrosting/css/AdminLTE-skins-all.css
@amosfolz

This comment has been minimized.

Copy link
Contributor

commented Jul 7, 2019

@lcharette do you remember what specifically these lines were meant to fix?

@lcharette

This comment has been minimized.

Copy link
Member Author

commented Jul 15, 2019

@lcharette

This comment has been minimized.

Copy link
Member Author

commented Jul 16, 2019

When upgrading to AdminLTE 3 later on, we should probably try using their NPM repo.

@lcharette

This comment has been minimized.

Copy link
Member Author

commented Jul 16, 2019

@amosfolz

This comment has been minimized.

Copy link
Contributor

commented Jul 16, 2019

Okay, updated to 2.4.14! Only a few lines of code changed.

@amosfolz

This comment has been minimized.

Copy link
Contributor

commented Jul 16, 2019

When upgrading to AdminLTE 3 later on, we should probably try using their NPM repo.

I'm not sure if it will be the same using their NPM repo or not, but the package is pretty large when downloading the ZIP file.
image

@lcharette lcharette closed this Jul 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.