Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve ordering by activity date #1062

Merged
merged 3 commits into from Jan 31, 2020
Merged

Improve ordering by activity date #1062

merged 3 commits into from Jan 31, 2020

Conversation

@ktecho
Copy link
Contributor

ktecho commented Jan 29, 2020

Some activity logs can occur at the same second, so ordering just by date can show the results unordered. As per @lcharette suggestion, we can order by occurred_at AND id. That should gives better results.

Some activity logs can occur at the same second, so ordering just by date can show the results unordered. As per @lcharette suggestion, we can order by `occurred_at` AND `id`. That should gives better results.
@codecov

This comment has been minimized.

Copy link

codecov bot commented Jan 29, 2020

Codecov Report

Merging #1062 into develop will increase coverage by 1%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##             develop    #1062    +/-   ##
===========================================
+ Coverage      66.79%   67.79%    +1%     
- Complexity      1933     1983    +50     
===========================================
  Files            162      172    +10     
  Lines           6748     6930   +182     
===========================================
+ Hits            4507     4698   +191     
+ Misses          2241     2232     -9
Impacted Files Coverage Δ Complexity Δ
...pp/sprinkles/admin/src/Sprunje/ActivitySprunje.php 16.66% <0%> (-4.77%) 5 <1> (+1)
.../sprinkles/core/src/Database/Migrator/Migrator.php 92.36% <0%> (-0.7%) 52% <0%> (ø)
app/sprinkles/core/src/Core.php 100% <0%> (ø) 13% <0%> (+1%) ⬆️
app/system/Sprinkle/SprinkleManager.php 100% <0%> (ø) 31% <0%> (+1%) ⬆️
app/system/Bakery/BaseCommand.php 100% <0%> (ø) 4% <0%> (ø) ⬇️
app/sprinkles/core/src/Bakery/DebugCommand.php 0% <0%> (ø) 12% <0%> (ø) ⬇️
...nkles/account/src/Controller/AccountController.php 100% <0%> (ø) 85% <0%> (ø) ⬇️
...inkles/core/src/Bakery/Helper/NodeVersionCheck.php 0% <0%> (ø) 4% <0%> (-2%) ⬇️
app/system/Sprinkle/Sprinkle.php 100% <0%> (ø) 7% <0%> (+3%) ⬆️
...prinkles/core/src/Filesystem/FilesystemManager.php 76.92% <0%> (ø) 6% <0%> (ø) ⬇️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e44425...7b91894. Read the comment docs.

@lcharette

This comment has been minimized.

@lcharette lcharette changed the base branch from master to develop Jan 29, 2020
@lcharette lcharette self-assigned this Jan 29, 2020
@lcharette lcharette added this to the 4.4.0 milestone Jan 29, 2020
@ktecho

This comment has been minimized.

Copy link
Contributor Author

ktecho commented Jan 29, 2020

@lcharette I re-added the whitespace but it's giving two fails. Do you know what could be happening?

@lcharette

This comment has been minimized.

Copy link
Member

lcharette commented Jan 30, 2020

Nan, you need to remove the whitespace.

FYI, Codecov failure can be ignored

@ktecho

This comment has been minimized.

Copy link
Contributor Author

ktecho commented Jan 30, 2020

@lcharette Should be done now

@lcharette lcharette merged commit 123ee0b into userfrosting:develop Jan 31, 2020
3 of 4 checks passed
3 of 4 checks passed
codecov/patch 0% of diff hit (target 66.79%)
Details
codecov/project 67.79% (+1%) compared to 6e44425
Details
continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.