Fixed hard user deletion #785
Conversation
| @@ -180,10 +180,10 @@ public function delete($hardDelete = false) | |||
| // TODO: remove any persistences | |||
|
|
|||
| // Delete the user | |||
| $result = parent::forceDelete(); | |||
There was a problem hiding this comment.
We don´t want the parents method here but the traits one. See https://github.com/laravel/framework/blob/4ab4e5f9470939e1c853196e1d5c84830c8b22e3/src/Illuminate/Database/Eloquent/Model.php#L1129
There was a problem hiding this comment.
Changing from delete to deleteUser breaks the model API - are you sure we need to change the name of the method?
There was a problem hiding this comment.
Otherwise the traits forceDelete Method calls the this method. See: https://github.com/laravel/framework/blob/5.4/src/Illuminate/Database/Eloquent/SoftDeletes.php#L33
There was a problem hiding this comment.
Ok, got it. It sounds like maybe overriding User::delete to support hard/soft deletes was a bad idea in the first place. But do we need a deleteUser method either? It sounds like maybe we should use model events to handle deleting/modifying related entities instead. Choosing to do a hard/soft delete could be handled in the controller method.
lcharette
requested review from
alexweissman
and removed request for
alexweissman
This https://github.com/laravel/framework/blob/5.4/src/Illuminate/Database/Eloquent/SoftDeletes.php#L33 method was causing an infinite loop on hard user deletion.