Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comments to .env.example file to show some options depending on platform #12

Closed
leanpanda opened this issue Mar 5, 2017 · 7 comments
Labels

Comments

@leanpanda
Copy link
Contributor

I dont know how to place comment lines inside the .env file but would like to add the following (if possible:)

//For example for MAMP you would write DB_HOST="127.0.0.1"

@lcharette
Copy link
Member

Could have a warning/info box on learn to explain that some environment (i.e. MAMP) requires 127.0.0.1 instead of localhost

@alexweissman
Copy link
Member

Seems like this is now handled in https://github.com/userfrosting/UserFrosting/blob/master/app/.env.example ? Is this handled in Bakery as well?

@lcharette
Copy link
Member

Bakery present the default for MySQL/sqlserv/prostgre, but not any note on stuff like MAMP
https://github.com/userfrosting/UserFrosting/blob/master/app/system/Bakery/Command/Setup.php#L98

@alexweissman
Copy link
Member

hmm, yeah maybe Bakery should mention that. Or could it detect MAMP and change the default based on that? 😲

@lcharette
Copy link
Member

How do you detect MAMP ?

Could add it to the db list though...

@alexweissman
Copy link
Member

Spit test?

@lcharette
Copy link
Member

Closing this as several improvement has been made to docs and bakery since. Further improvement could be made directly in the doc. Feel free to reopen a new issue/pr if necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants