Feature request: allow themes to provide colour settings

[robertrossmann]

It would be great to allow theme authors to provide colour settings for this package. Unfortunately if the colours are defined via settings I believe theme authors have no way of providing themed colours for them and users need to change the colours themselves.

I would love to define the colour scheme for this package in Remedy theme. 🙏

Thanks in advance!

[usernamehw]

Do you think it's possible without introducing breaking changes?

[usernamehw]

Nice theme btw.

[robertrossmann]

Sadly, I would not know - the only extension I ever worked on for VS Code was that theme and that's just flat JSON. I do not know how custom colour "contributions" work or what would be necessary to adopt them here. I'd just love to have the possibility to provide those colours through that theme.

Thanks! ❤️ Just released version 3.0 of it. 🚀

[usernamehw]

Some comparison of the properties that are known to me:

	Color	Setting
Can get the value	❌	✅
Can change the value from settings GUI	❌	✅
Auto complete default/current value in settings	❌	✅
Color picker in settings.json	✅	❌
Assign color per theme	✅	❌
Use id of an existing color	✅❌	✅❌

There is no way of getting the value (inline svg gutter icon/ css injected style won't work with color) microsoft/vscode#32813

Fill in current value in settings: microsoft/vscode#25633

[usernamehw]

The plan is to make this in a multi-step way.

• Create color contributions
• Make them under a config errorLens.useColorContributions (false by default)
• Create light color contribution variants
• Create command that transfers colors from settings to their Color contributions equivalent.
• In the future: set it to true
• If it can completely replace the settings - then delete settings. Otherwise - delete color contributions.

[usernamehw]

Added color tokens:

• errorLens.errorBackground
• errorLens.errorMessageBackground
• errorLens.errorForeground
• errorLens.warningBackground
• errorLens.warningMessageBackground
• errorLens.warningForeground
• errorLens.infoBackground
• errorLens.infoMessageBackground
• errorLens.infoForeground
• errorLens.hintBackground
• errorLens.hintMessageBackground
• errorLens.hintForeground

You can test them from 2.8.0 with

"errorLens.useColorContributions": true,

[robertrossmann]

Thank @usernamehw for implementing this! ❤️ I have released Remedy v3.4 with colour contributions for this extension and it works great! Here, a screenshot of how it looks like when you install this extension and the Remedy theme - the colours exactly match other decorations of the same type.

I guess the only last missing thing would be to allow defining custom colour for the circle gutter marker, if that is possible. Otherwise I am very happy with this now! 🍻 🎨

[RobFosterNYC]

I would like to say thank you to @usernamehw
you really made my month. ive been waiting for updates on this extension for a very long time.
this makes me so happy. Again thank you for forking and fixing this extension and making it available.
Thank you :D

[usernamehw]

I'm closing this since most of the work is done.

[Alecton4]

Thank @usernamehw for implementing this! ❤️ I have released Remedy v3.4 with colour contributions for this extension and it works great! Here, a screenshot of how it looks like when you install this extension and the Remedy theme - the colours exactly match other decorations of the same type.

I guess the only last missing thing would be to allow defining custom colour for the circle gutter marker, if that is possible. Otherwise I am very happy with this now! 🍻 🎨

Sorry for creating a reply here, but what is the setting to display "inline icon" as shown in your picture? I think this is nice, but I don't have it and cannot find the setting for it. Did they remove this feature?

[usernamehw]

It's $severity from the inline message template:

"errorLens.messageTemplate": "$severity $message",
"errorLens.severityText": ["❗", "⚠", "ℹ", "👉"],