Update for filters and if from_user is None #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jusidama-Bot
changed the title
modified: pyromod/listen/listen.py modified: pyromod/utils/utils.py
modified: pyromod/utils/utils.py
modified: pyromod/utils/utils.py
modified: pyromod/utils/utils.py
modified: pyromod/listen/listen.py
|
Hey, thanks for your effort on this huge contribution! I did not understand at first why I'm going to fix the conflicts, then merge the PR and then merge the changes onto the brand new refactored pyromod v3 Thank you! |
usernein
added a commit
that referenced
this pull request
Oct 29, 2023
* Update listen.py * Update listen.py * Update utils.py * Changes to be committed: modified: pyromod/listen/listen.py modified: pyromod/utils/utils.py * Changes to be committed: modified: pyromod/utils/utils.py * Changes to be committed: modified: pyromod/utils/utils.py * Changes to be committed: modified: pyromod/utils/utils.py * Update utils.py * Update utils.py * Update utils.py * Update utils.py * Update utils.py * Update utils.py * Update utils.py * Update utils.py * Changes to be committed: modified: pyromod/listen/listen.py * Update pyproject.toml * Update poetry.lock * Update poetry.lock * Update pyproject.toml * Update listen.py * Update listen.py --------- Co-authored-by: Cezar H <pauxiscezar@gmail.com>
usernein
added a commit
that referenced
this pull request
Oct 29, 2023
* feat: remove identifier of listen() and ask() in favor of new kwargs * refactor: split classes into new files, extend from original classes * refactor: rename patch -> patch_into, patchable -> should_patch * style: format with ruff * feat(precedence): return most specific listener * refactor!: rename get_single_listener -> get_matching_listener, get_many_listeners -> get_many_matching_listeners * refactor: improve variable names and only remove checking attribute from null listener * refactor: transform config.py into package pyromod.config * chore!: remove handlers from pyromod exports * docs: bring new docs with docsify * docs: update README * Create CNAME * Delete CNAME * docs: add missing backtick * Create CNAME * fix: fix order of positional args in bound method ask * refactor(ask)!: rename request to sent_message * feat(ask): send message only if text is not empty * refactor: search for message_id (pyrogram v1) if message.id is not found * refactor: only use query.message.chat.id if both message and chat are not null * supports pyrogram v1 (#11) * supports pyrogram v1 * Update listen.py forgot, delete comma --------- Co-authored-by: Cezar H <pauxiscezar@gmail.com> * request to sent_message (#13) I think using the sent_message statement instead of request is much more descriptive * ask function will behave like listen if text is empty (#14) Co-authored-by: Cezar H <pauxiscezar@gmail.com> * Update for filters and if from_user is None (#17) * Update listen.py * Update listen.py * Update utils.py * Changes to be committed: modified: pyromod/listen/listen.py modified: pyromod/utils/utils.py * Changes to be committed: modified: pyromod/utils/utils.py * Changes to be committed: modified: pyromod/utils/utils.py * Changes to be committed: modified: pyromod/utils/utils.py * Update utils.py * Update utils.py * Update utils.py * Update utils.py * Update utils.py * Update utils.py * Update utils.py * Update utils.py * Changes to be committed: modified: pyromod/listen/listen.py * Update pyproject.toml * Update poetry.lock * Update poetry.lock * Update pyproject.toml * Update listen.py * Update listen.py --------- Co-authored-by: Cezar H <pauxiscezar@gmail.com> * feat: remove identifier of listen() and ask() in favor of new kwargs * refactor: split classes into new files, extend from original classes * refactor: rename patch -> patch_into, patchable -> should_patch * refactor: rename patch -> patch_into * style: format with ruff * chore: remaking many changes that got undone after the merge * refactor!: rename get_single_listener -> get_matching_listener, get_many_listeners -> get_many_matching_listeners * feat(precedence): return most specific listener * fix: replace @should_patch -> @should_patch() * fix: use Dict and List from typing instead of builtin --------- Co-authored-by: Tofik Denianto <77754555+tofikdn@users.noreply.github.com> Co-authored-by: Eikosa <darkofheking@gmail.com> Co-authored-by: Ｊｕｓｉｄａｍａ Ｂｏｔ <97734754+Jusidama-Bot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix if user_id is None and if filters is not async