Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't save my choice, when i want enable "Mirror source code" and "style metadata" updates #60

Closed
decembre opened this issue May 27, 2021 · 4 comments
Labels
bug Something isn't working
Projects

Comments

@decembre
Copy link

decembre commented May 27, 2021

Don't save my choice, when i want enable:
Mirror style metadata (only for styles from USo-archive)
Mirror source code updates
Message on the title textarera:
"Modifier la valeur pour correspondre au format demandé"
That's about an imported userstyle:
Télérama - Voir Notes (Sans Inscription)
At the import, no way to choose "Mirror Update" (just the le mention of it).

@decembre decembre added the bug Something isn't working label May 27, 2021
@Gusted
Copy link
Member

Gusted commented May 27, 2021

Don't save my choice, when i want enable:
Mirror style metadata (only for styles from USo-archive)
Mirror source code updates

As it's a per-style choice and currently indeed not being saved.

@decembre
Copy link
Author

I don't understand....

@vednoc
Copy link
Member

vednoc commented May 27, 2021

This is because we only allow a-zA-Z0-9!@#$%-_ characters in the userstyle name. @Gusted I think it's about time we discuss how to go about this, so that we can avoid having similar issues in the future.

@decembre I tried it locally and, for the time being, you can fix this by replacing Télérama with Telerama.

@decembre
Copy link
Author

Thanks for the infos!

@vednoc vednoc closed this as completed in b1eb15b May 29, 2021
@vednoc vednoc added this to Done in Roadmap May 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Roadmap
  
Done
Development

No branches or pull requests

3 participants