Release PR - Combine #5 and #6 #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Given a choice between supporting EOL rubies, and giving up squiggly heredocs... goodbye to the past!
- Just about any version of rake that can be installed with the supported rubies will do what we need
- When splitting up the pairs, limit it to 2 pieces. That way the pairs are really pairs
- Otherwise multiline values break like crazy - Update specs that would fail otherwise, to show that you must quote numbers containing commas - See ruby/psych#273 for why..
Resolved Conflicts: lib/biscuit/secrets_decrypter.rb spec/lib/secrets_decrypter_spec.rb
nevinera
approved these changes
Oct 16, 2019
cdimartino
approved these changes
Oct 23, 2019
Keeping Suan on - credit due where credit is due!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Combines #5 and #6 into a single PR, with some conflicts resolved.
Going to QA based off this for a bit..