Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to 20160719 #4

Merged
merged 2 commits into from
Oct 7, 2016
Merged

Update to 20160719 #4

merged 2 commits into from
Oct 7, 2016

Conversation

petemounce
Copy link
Contributor

Fixes #1.

Added myself to authors.

I've tested x64 myself, but I don't have an x86 box to try out. I believe that chocolatey moderation automation does that now.

Peter Mounce added 2 commits August 17, 2016 11:14
The download contains a tarball which also needs to be extracted. My version of 7z did not extract transitively, so the install failed
Added myself to authors.
I've tested x64 myself, but I don't have an x86 box to try out. I believe that chocolatey moderation automation does that now.
@petemounce petemounce mentioned this pull request Aug 17, 2016
@userzimmermann userzimmermann self-assigned this Sep 29, 2016
userzimmermann added a commit that referenced this pull request Oct 7, 2016
@petemounce Thanks for those fixes! I hadn't take a look at that code for a long time :/
Anyway... it definitely needs an update now :)
I will continue with #4 then...
Copy link
Owner

@userzimmermann userzimmermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything fine again... almost ;) <authors> is used for the original software developers. I will move you to <owners> later...

Copy link
Owner

@userzimmermann userzimmermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also thanks for update of CHANGES.md

@userzimmermann userzimmermann mentioned this pull request Oct 7, 2016
@userzimmermann
Copy link
Owner

userzimmermann commented Oct 7, 2016

Hi @petemounce again :) Thanks for the update! That package had got so unusable... ;( I will merge this now and then move it to the msys2 branch. Please open further msys2 package PRs against that branch.

@userzimmermann userzimmermann merged commit 77f6111 into userzimmermann:master Oct 7, 2016
@userzimmermann
Copy link
Owner

@petemounce I will also add you to the Copyright. If you don't complain ;)

@petemounce
Copy link
Contributor Author

That's fine. Thanks for review and merge!

@petemounce petemounce deleted the update_to_20160719 branch October 7, 2016 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants