-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to 20160719 #4
Update to 20160719 #4
Conversation
The download contains a tarball which also needs to be extracted. My version of 7z did not extract transitively, so the install failed
Added myself to authors. I've tested x64 myself, but I don't have an x86 box to try out. I believe that chocolatey moderation automation does that now.
@petemounce Thanks for those fixes! I hadn't take a look at that code for a long time :/ Anyway... it definitely needs an update now :) I will continue with #4 then...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything fine again... almost ;) <authors>
is used for the original software developers. I will move you to <owners>
later...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also thanks for update of CHANGES.md
Hi @petemounce again :) Thanks for the update! That package had got so unusable... ;( I will merge this now and then move it to the msys2 branch. Please open further msys2 package PRs against that branch. |
@petemounce I will also add you to the Copyright. If you don't complain ;) |
That's fine. Thanks for review and merge! |
Fixes #1.
Added myself to authors.
I've tested x64 myself, but I don't have an x86 box to try out. I believe that chocolatey moderation automation does that now.