Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make story_type optional in StoryChange. #76

Merged
merged 1 commit into from
Jul 29, 2020

Conversation

mattspitz
Copy link
Contributor

Every other parameter is optional. I'm able to ignore it by casting a
params object as any, but I shouldn't have to do that.

Every other parameter is optional. I'm able to ignore it by casting a
`params` object as `any`, but I shouldn't have to do that.
@charpeni charpeni changed the base branch from master to main July 10, 2020 17:56
Copy link
Member

@charpeni charpeni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, good catch!

@charpeni charpeni merged commit 3af721b into useshortcut:main Jul 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants