Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix labels type in StoryChange #78

Merged
merged 1 commit into from
Sep 16, 2020
Merged

Fix labels type in StoryChange #78

merged 1 commit into from
Sep 16, 2020

Conversation

ybhan
Copy link
Contributor

@ybhan ybhan commented Jul 15, 2020

The type of labels in StoryChange class, which is used for createStory and updateStory, should be Array<CreateLabelParams> instead of Array<Label>, as illustrated at https://clubhouse.io/api/rest/v3/#Create-Story

Screen Shot 2020-07-14 at 11 35 18 PM

Before fixing, passing an Array<Label> will receive "Error 400: Schema mismatch".

@ybhan
Copy link
Contributor Author

ybhan commented Sep 16, 2020

Please review! @charpeni @maryjenel Thanks!

Copy link
Member

@charpeni charpeni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sending this!

@charpeni charpeni merged commit 08a9f88 into useshortcut:main Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants